[GitHub] spark pull request: Fixes SPARK-12910: R version for installing sp...

[napsternxg]

Github user napsternxg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10836#discussion_r50189970
  
    --- Diff: R/install-dev.sh ---
    @@ -35,12 +35,19 @@ LIB_DIR="$FWDIR/lib"
     mkdir -p $LIB_DIR
     
     pushd $FWDIR > /dev/null
    +if [ ! -z "$1" ]
    +  then
    +    R_HOME="$1/bin"
    +   else
    +    R_HOME="$(dirname $(which R))"
    --- End diff --
    
    I have made the fix. 
    
    Here are my new test results:
    
    ```
    $ unset R_HOME
    ram:/content/username/SOFTWARE/spark/R $ ./install-dev.sh 
    USING R_HOME = 
    ERROR: this R is version 2.15.1, package 'SparkR' requires R >= 3.0
    * removing ‘/content/username/SOFTWARE/spark/R/lib/SparkR’
    ram:/content/username/SOFTWARE/spark/R $ export 
R_HOME=/content/username/SOFTWARE/R-3.2.3
    ram:/content/username/SOFTWARE/spark/R $ ./install-dev.sh 
    USING R_HOME = /content/username/SOFTWARE/R-3.2.3
    * installing *source* package ‘SparkR’ ...
    ** R
    ** inst
    ** preparing package for lazy loading
    Creating a new generic function for ‘colnames’ in package 
‘SparkR’
    Creating a new generic function for ‘colnames<-’ in package 
‘SparkR’
    Creating a new generic function for ‘cov’ in package 
‘SparkR’
    Creating a new generic function for ‘na.omit’ in package 
‘SparkR’
    Creating a new generic function for ‘filter’ in package 
‘SparkR’
    Creating a new generic function for ‘intersect’ in package 
‘SparkR’
    Creating a new generic function for ‘sample’ in package 
‘SparkR’
    Creating a new generic function for ‘transform’ in package 
‘SparkR’
    Creating a new generic function for ‘subset’ in package 
‘SparkR’
    Creating a new generic function for ‘summary’ in package 
‘SparkR’
    Creating a new generic function for ‘lag’ in package 
‘SparkR’
    Creating a new generic function for ‘rank’ in package 
‘SparkR’
    Creating a new generic function for ‘sd’ in package 
‘SparkR’
    Creating a new generic function for ‘var’ in package 
‘SparkR’
    Creating a new generic function for ‘predict’ in package 
‘SparkR’
    Creating a new generic function for ‘rbind’ in package 
‘SparkR’
    Creating a generic function for ‘lapply’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘Filter’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘alias’ from package 
‘stats’ in package ‘SparkR’
    Creating a generic function for ‘substr’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘%in%’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘mean’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘unique’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘nrow’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘ncol’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘head’ from package 
‘utils’ in package ‘SparkR’
    Creating a generic function for ‘factorial’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘atan2’ from package 
‘base’ in package ‘SparkR’
    Creating a generic function for ‘ifelse’ from package 
‘base’ in package ‘SparkR’
    ** help
    No man pages found in package  ‘SparkR’ 
    *** installing help indices
    ** building package indices
    ** testing if installed package can be loaded
    * DONE (SparkR)
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org