Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10860#discussion_r50739205
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ---
    @@ -406,10 +380,9 @@ class FsHistoryProviderSuite extends SparkFunSuite 
with BeforeAndAfter with Matc
           SparkListenerApplicationStart("v10Log", None, 2L, "test", None),
           SparkListenerApplicationEnd(4L))
     
    +    // Old-style logs are ignored.
    --- End diff --
    
    You should remove `writeOldLog` and code related to it. If you really want 
to make sure old logs are ignored, just create a directory with some empty 
files in it, not need to make it look like a proper old log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to