Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/11012#discussion_r51643796
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -304,10 +309,9 @@ private[spark] class MemoryStore(blockManager:
BlockManager, memoryManager: Memo
// release the unroll memory yet. Instead, we transfer it to
pending unroll memory
// so `tryToPut` can further transfer it to normal storage
memory later.
// TODO: we can probably express this without pending unroll
memory (SPARK-10907)
- val amountToTransferToPending = currentUnrollMemoryForThisTask -
previousMemoryReserved
--- End diff --
Per my earlier comment, I updated the PR to use to use a var named
previousMemoryReserved to manually track the number of unroll bytes allocated
during a given invocation of unrollSafely rather than relying on
unrollMemoryMap(taskAttemptId) not being modified outside of the given thread
between the assignment to previousMemoryReserved and the memory maps being
updated in the finally { } block. This should remove the need to make the whole
method synchronized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
