Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/11012#discussion_r51645315
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -304,10 +309,9 @@ private[spark] class MemoryStore(blockManager:
BlockManager, memoryManager: Memo
// release the unroll memory yet. Instead, we transfer it to
pending unroll memory
// so `tryToPut` can further transfer it to normal storage
memory later.
// TODO: we can probably express this without pending unroll
memory (SPARK-10907)
- val amountToTransferToPending = currentUnrollMemoryForThisTask -
previousMemoryReserved
--- End diff --
@nongli â the problem is that the original implementation assumes that
previousMemoryReserved is an invariant representing the number of unroll bytes
allocated for the process besides the pending bytes allocated during the
unroll, but no synchronization exists to enforce this invariant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
