Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11119#discussion_r52390583 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala --- @@ -78,7 +78,24 @@ private[shared] object SharedParamsCodeGen { ParamDesc[String]("solver", "the solver algorithm for optimization. If this is not set or " + "empty, default value is 'auto'.", Some("\"auto\""))) - val code = genSharedParams(params) + // scalastyle:off + val extras: Seq[String] = Seq( + """ + |private[ml] trait HasInitialModel[T <: Model[T]] extends Params { + | + | /** + | * Param for initial model of warm start. --- End diff -- I prefer to put them in a separate place for this PR because I don't want to get involved in too many features in a single PR. Let's add follow-up JIRAs for other features.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org