Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11119#discussion_r52391718
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -248,6 +269,11 @@ class KMeans @Since("1.5.0") (
.setMaxIterations($(maxIter))
.setSeed($(seed))
.setEpsilon($(tol))
+
+ if (isSet(initialModel)) {
+ algo.setInitialModel($(initialModel).parentModel)
--- End diff --
1. MLlibKMeans doesn't check dimension match. If we want to check the dim,
there are two ways, either use `rdd.first().size()` to get the dim, or we
extract dim from attributes of DataFrame. The latter one is better but it need
support from `Attribute`.
2. The `parentModel` of a `KMeansModel` is a `MLlibKMeansModel`, which
supports cluster centers for `KMeans`. And `algo` is a `MLlibKMeans`. You can
refer to the definition of `KMeanModel` in ML package. In fact, the name of
`parentModel` is misleading.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
