Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11048#discussion_r52644696
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -62,6 +66,458 @@ private[sql] class SparkQl(conf: ParserConf =
SimpleParserConf()) extends Cataly
val tableIdent = extractTableIdent(nameParts)
RefreshTable(tableIdent)
+ case Token("TOK_CREATEDATABASE", Token(databaseName, Nil) ::
createDatabaseArgs) =>
--- End diff --
The main problem is LogicalPlan parsing, which we can split up in
command/ddl/query parsing. We could use partial functions (or something like
that) to implement the different parts of the parsing logic.
For instance:
abstract class BaseParser(val conf: ParserConf) extends ParserInterface
{
val planParsers: Seq[PlanParser]
lazy val planParser = planParsers.reduce(_.orElse(_))
def nodeToPlan(node: ASTNode): LogicalPlan = {
planParser.applyOrElse(node, throw new
NotImplementedError(node.text))
}
}
abstract class PlanParser extends PartialFunction[ASTNode, LogicalPlan]
case class ExplainCommandParser(base: BaseParser) extends PlanParser {
val catalystQl = new CatalystQl
import catalystQl.Token
override def isDefinedAt(node: ASTNode): Boolean = node.text ==
"TOK_EXPLAIN"
override def apply(v1: ASTNode): LogicalPlan = v1.children match {
case (crtTbl @ Token("TOK_CREATETABLE" | "TOK_QUERY", _)) :: rest =>
val extended = rest.exists(_.text.toUpperCase == "EXTENDED")
ExplainCommand(base.nodeToPlan(crtTbl), extended)
}
}
class SomeParser(conf: ParserConf) extends BaseParser {
val planParsers: Seq[PlanParser] = Seq(
ExplainCommandParser(this))
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
