Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1460#discussion_r15263661
--- Diff: python/pyspark/shuffle.py ---
@@ -0,0 +1,378 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import os
+import sys
+import platform
+import shutil
+import warnings
+
+from pyspark.serializers import BatchedSerializer, PickleSerializer
+
+try:
+ import psutil
+
+ def get_used_memory():
+ self = psutil.Process(os.getpid())
+ return self.memory_info().rss >> 20
+
+except ImportError:
+
+ def get_used_memory():
+ if platform.system() == 'Linux':
+ for line in open('/proc/self/status'):
+ if line.startswith('VmRSS:'):
+ return int(line.split()[1]) >> 10
+ else:
+ warnings.warn("please install psutil to get accurate memory
usage")
+ if platform.system() == "Darwin":
+ import resource
+ return resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
>> 20
+ # TODO: support windows
+ return 0
+
+
+class Aggregator(object):
+
+ def __init__(self, creator, combiner, mergeCombiner=None):
+ self.creator = creator
+ self.combiner = combiner
+ self.mergeCombiner = mergeCombiner or combiner
--- End diff --
Call the fields of this createCombiner, mergeValue and mergeCombiners, same
as in Scala. Also explain what it means for mergeCombiners to be None.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
