Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11083#discussion_r53563471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -213,7 +235,10 @@ case class RoundRobinPartitioning(numPartitions: Int)
extends Partitioning {
case object SinglePartition extends Partitioning {
val numPartitions = 1
- override def satisfies(required: Distribution): Boolean = true
+ override def satisfies(required: Distribution): Boolean = required match
{
+ case _: BroadcastDistribution => false
--- End diff --
i think this is ok for now, but technically we don't need to introduce an
exchange if both sides of the join have only one partition. i guess this
framework does not currently handle that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
