Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11083#discussion_r53563479
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
 ---
    @@ -76,6 +77,27 @@ case class OrderedDistribution(ordering: Seq[SortOrder]) 
extends Distribution {
     }
     
     /**
    + * Marker trait to identify the shape in which tuples are broadcasted. 
Typical examples of this are
    + * identity (tuples remain unchanged) or hashed (tuples are converted into 
some hash index).
    + */
    +trait BroadcastMode {
    +  def transform(rows: Array[InternalRow]): Any
    +}
    +
    +/**
    + * IdentityBroadcastMode requires that rows are broadcasted in their 
original form.
    + */
    +case object IdentityBroadcastMode extends BroadcastMode {
    +  override def transform(rows: Array[InternalRow]): Array[InternalRow] = 
rows
    +}
    +
    +/**
    +  * Represents data where tuples are broadcasted to every node. It is 
quite common that the
    +  * entire set of tuples is transformed into different data structure.
    +  */
    +case class BroadcastDistribution(mode: BroadcastMode) extends Distribution
    --- End diff --
    
    ok for now, but technically once we introduce this, "Distribution" is not 
just about "distribution" anymore, but rather some data property.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to