Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1538#discussion_r15321332
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
    @@ -62,20 +62,23 @@ object CommandUtils extends Logging {
             val joined = 
command.libraryPathEntries.mkString(File.pathSeparator)
             Seq(s"-Djava.library.path=$joined")
           } else {
    -         Seq()
    +        Seq()
           }
     
         val permGenOpt = Seq("-XX:MaxPermSize=128m")
     
    +    // Convert Spark properties to java system properties
    +    val sparkOpts = command.sparkProps.map { case (k, v) => s"-D$k=$v" }
    --- End diff --
    
    Yeah I agree - it would be better to only set this for the driver, this 
`buildJavaOpts` is used for both executors and the driver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to