Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1538#discussion_r15321907
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
@@ -62,20 +62,23 @@ object CommandUtils extends Logging {
val joined =
command.libraryPathEntries.mkString(File.pathSeparator)
Seq(s"-Djava.library.path=$joined")
} else {
- Seq()
+ Seq()
}
val permGenOpt = Seq("-XX:MaxPermSize=128m")
+ // Convert Spark properties to java system properties
+ val sparkOpts = command.sparkProps.map { case (k, v) => s"-D$k=$v" }
--- End diff --
Note that the logic here is more equivalent to
https://github.com/apache/spark/blob/master/yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala#L388,
because the driver needs basic configs like `spark.master` and
`spark.app.name` to launch the SparkContext in addition to just akka and
authentication configs.
But yes, when we launch the executors we might actually want to only filter
out the akka and authentication ones, and pull in the rest from the driver
later on, similar to how yarn handles it in your link.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
