Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55079563
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -116,6 +119,39 @@ trait CodegenSupport extends SparkPlan {
}
/**
+ * Returns source code to evaluate all the variables, and clear the
code of them, to prevent
+ * them to be evaluated twice.
+ */
+ protected def evaluateVariables(variables: Seq[ExprCode]): String = {
+ val evaluate = variables.filter(_.code !=
"").map(_.code.trim).mkString("\n")
+ variables.foreach(_.code = "")
+ evaluate
+ }
+
+ /**
+ * Returns source code to evaluate the variables for required
attributes, and clear the code
+ * of evaluated variables, to prevent them to be evaluated twice..
+ */
+ protected def evaluateRequiredVariables(
+ attributes: Seq[Attribute],
+ variables: Seq[ExprCode],
+ required: AttributeSet): String = {
+ var evaluateVars = ""
+ variables.zipWithIndex.foreach { case (ev, i) =>
+ if (ev.code != "" && required.contains(attributes(i))) {
+ evaluateVars += ev.code.trim + "\n"
+ ev.code = ""
+ }
+ }
+ evaluateVars
+ }
+
+ /**
+ * The subset of inputSet those should be evaluated before this plan.
+ */
+ def usedInputs: AttributeSet = references
+
+ /**
* Consume the columns generated from it's child, call doConsume() or
emit the rows.
--- End diff --
Can you comment what the semantics are if row == null vs not null?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
