Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11274#discussion_r55080224
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala 
---
    @@ -116,6 +119,39 @@ trait CodegenSupport extends SparkPlan {
       }
     
       /**
    +    * Returns source code to evaluate all the variables, and clear the 
code of them, to prevent
    --- End diff --
    
    I was imagining something like:
    
    evaluateAttributes(Seq[Expression]) which evaluates all the attribute 
refernces in the tree that haven't been. This is kind of similar to what you 
have below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to