Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11466#discussion_r55118055
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -78,6 +78,27 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:
SQLContext) extends Loggi
}
}
+ private def toSQL(node: LogicalPlan, topNode: Boolean): String = {
--- End diff --
Yea, I see. Join is the top node only when using DataFrame API. But the
original purpose of this change is not intended to support converting logical
plan of DataFrame to SQL. The test case is just used to construct the Join plan
needed to test it. This change is introduced to support the option to convert a
logical plan not beginning from the top of the whole plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
