Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11466#discussion_r55118235
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -78,6 +78,27 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:
SQLContext) extends Loggi
}
}
+ private def toSQL(node: LogicalPlan, topNode: Boolean): String = {
--- End diff --
If my understanding is not wrong, you want to support SQL generation from a
partial analyzed plan. If so, do you have any use case?
So far, our SQL generation assumes the plan is complete and generated by
the SQL parser. If not, I am afraid, it could generate a wrong SQL statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
