Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55316476
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command
+
+import org.apache.spark.Logging
+import org.apache.spark.sql.{Row, SQLContext}
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.expressions.{Attribute,
AttributeReference}
+import org.apache.spark.sql.execution.datasources.BucketSpec
+import org.apache.spark.sql.types._
+
+
+/**
+ * A DDL command expected to be run in the underlying system without Spark
parsing the
+ * query text.
+ */
+abstract class NativeDDLCommands(val sql: String) extends RunnableCommand {
+
+ override def run(sqlContext: SQLContext): Seq[Row] = {
+ sqlContext.runNativeSql(sql)
+ }
+
+ override val output: Seq[Attribute] = {
+ Seq(AttributeReference("result", StringType, nullable = false)())
+ }
+
+}
+
+case class CreateDatabase(
+ databaseName: String,
+ allowExisting: Boolean,
+ path: Option[String],
+ comment: Option[String],
+ props: Map[String, String])(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class CreateFunction(
+ functionName: String,
+ alias: String,
+ resourcesMap: Map[String, String],
+ isTemp: Boolean)(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class AlterTableRename(
+ tableName: TableIdentifier,
+ renameTableName: TableIdentifier)(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class AlterTableSetProperties(
+ tableName: TableIdentifier,
+ setProperties: Map[String, Option[String]])(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class AlterTableDropProperties(
+ tableName: TableIdentifier,
+ dropProperties: Map[String, Option[String]],
+ allowExisting: Boolean)(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class AlterTableSerDeProperties(
+ tableName: TableIdentifier,
+ serdeClassName: Option[String],
+ serdeProperties: Option[Map[String, Option[String]]],
+ partition: Option[Map[String, Option[String]]])(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class AlterTableStoreProperties(
+ tableName: TableIdentifier,
+ buckets: Option[BucketSpec],
+ // TODO: use `clustered` and `sorted` instead for simplicity
+ noClustered: Boolean,
+ noSorted: Boolean)(sql: String)
+ extends NativeDDLCommands(sql) with Logging
+
+case class AlterTableSkewed(
+ tableName: TableIdentifier,
+ skewedCols: Seq[String],
+ skewedValues: Seq[Seq[String]],
+ storedAsDirs: Boolean,
+ notSkewed: Boolean,
+ // TODO: what??
+ notStoredAsDirs: Boolean)(sql: String)
--- End diff --
@viirya I'm really confused about this flag. We have another one called
`storedAsDirs` and this one says `notStoredAsDirs`. It would seem that one is
always the opposite of the other, but that's not actually the case in tests,
e.g.
```
// DDLCommandSuite, "alter table: skewed"
val expected3 = AlterTableSkewed(
TableIdentifier("table_name", None),
Seq("dt", "country"),
Seq(List("2008-08-08", "us"), List("2009-09-09", "uk")),
storedAsDirs = false,
notSkewed = false,
notStoredAsDirs = false)(sql3)
```
seems contradictory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
