Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11599#discussion_r55480282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -380,6 +380,9 @@ object ColumnPruning extends Rule[LogicalPlan] {
p
}
+ // Eliminate the Projects with empty projectList
+ case p @ Project(projectList, child) if projectList.isEmpty => child
--- End diff --
I'm thinking of the correctness of this rule. Actually this is not column
pruning, but add more columns, as `child` may have more one columns.
And why this rule `case p @ Project(projectList, child) if
sameOutput(child.output, p.output) => child` can't work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
