Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11599#discussion_r55482082
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -380,6 +380,9 @@ object ColumnPruning extends Rule[LogicalPlan] {
p
}
+ // Eliminate the Projects with empty projectList
+ case p @ Project(projectList, child) if projectList.isEmpty => child
--- End diff --
Thanks @viirya @cloud-fan !
I am not sure which way is better.
```scala
case p @ Project(_, l: LeafNode) if !l.isInstanceOf[OneRowRelation] => p
```
My concern is the above line looks more hacky than the current PR fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
