Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/11724#discussion_r56266282
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -108,14 +109,38 @@ private[csv] object CSVInferSchema {
}
private def tryParseDouble(field: String): DataType = {
- if ((allCatch opt field.toDouble).isDefined) {
+ val doubleTry = allCatch opt field.toDouble
--- End diff --
Hm.. then wouldn't any data be inferred as `DoubleType`?
I mean, if `DecimalType` is checked first then any numeric types having the
lower priority would not be inferred because all the numeric types can be
represented by `DecimalType`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
