Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/11724#issuecomment-197089379
Just to make sure that checking precision work fine, the codes below work
correctly.
```scala
import java.math.BigDecimal
import scala.util.control.Exception._
def isKeepingPrecision(field: String): Boolean = {
val doubleTry = allCatch opt field.toDouble
val roundtripTry = doubleTry.map(BigDecimal.valueOf)
val decimalTryOther = allCatch opt new BigDecimal(field)
roundtripTry == decimalTryOther && doubleTry.isDefined
}
val losingPrecisionDoubles = Seq("10000000000000001", "-10000000000000001",
"1.0000000000000001", "1.0000000000000001", "9223372036854775808")
val keepingPrecisionDoubles = Seq("1.1", "1.2345")
losingPrecisionDoubles.foreach(value => println(isLosingPrecision(value)))
doubles.foreach(value => println(isLosingPrecision(value)))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
