Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11747#discussion_r56312310
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
    @@ -476,3 +480,19 @@ private class ListenerThatAcceptsSparkConf(conf: 
SparkConf) extends SparkListene
       var count = 0
       override def onJobEnd(job: SparkListenerJobEnd): Unit = count += 1
     }
    +
    +private class SlowShuffleManager(conf: SparkConf) extends 
SortShuffleManager(conf) {
    +  
    +  override val shuffleBlockResolver: IndexShuffleBlockResolver =
    +    new SlowIndexShuffleBlockResolver(conf)
    +    
    +    private class SlowIndexShuffleBlockResolver(conf: SparkConf,
    --- End diff --
    
    Exactly, that seems simpler


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to