Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11747#discussion_r56408595
--- Diff: core/src/test/scala/org/apache/spark/LocalSparkContext.scala ---
@@ -27,12 +27,12 @@ trait LocalSparkContext extends BeforeAndAfterEach with
BeforeAndAfterAll { self
@transient var sc: SparkContext = _
- override def beforeAll() {
+ override def beforeAll(): Unit = {
--- End diff --
I think you could take it out of this PR. There are so many instances of
this syntax that I'm not even sure it's worth changing everywhere. It's fine to
fix if you're already modifying the surrounding code, but this is unrelated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
