Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56455795
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -60,17 +60,28 @@ case class BoundReference(ordinal: Int, dataType:
DataType, nullable: Boolean)
override def genCode(ctx: CodegenContext, ev: ExprCode): String = {
val javaType = ctx.javaType(dataType)
- val value = ctx.getValue(ctx.INPUT_ROW, dataType, ordinal.toString)
+ val value = if (!ctx.isColumnarType(ctx.INPUT_ROW)) {
+ ctx.getValue(ctx.INPUT_ROW, dataType, ordinal.toString)
+ } else {
+ ctx.getValue(ctx.INPUT_ROW, dataType, ctx.INPUT_COLORDINAL)
--- End diff --
Since it's only used in one place, I'd like to narrow down the changes,
it's easier to maintain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
