Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56335579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -186,6 +190,13 @@ class CodegenContext {
freshNameIds += fullName -> 1
fullName
}
+ freshNameJavaTypes.put(freshname, javaType)
+ freshname
+ }
+
+ def isColumnarType(name: String): Boolean = {
--- End diff --
The bottom line is that we need to maintain this for each variable. For
example, ```scanBatches()```, we need to access ```InternalRow``` for a column
with ```struct``` type (e.g. ```ColumnVector.getStruct()``` is called. In my
first prototype, I set ```true``` into ```ctx.columnarInput```. However, I
cannot support such a complex case.
I will replace lookup this by name with lookup this by setting a flag in
`freshName()` to avoid brittleness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
