Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56725827
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
// TODO: The abstractions between this class and SqlNewHadoopRDD makes
it difficult to know
// here which path to use. Fix this.
- ctx.INPUT_ROW = row
ctx.currentVars = null
- val columns1 = exprs.map(_.gen(ctx))
+ val colVars = output.zipWithIndex.map(x => ctx.freshName("col" + x._2))
+ val colDeclarations = colVars.zipWithIndex.map(x => {
+ (columnVectorClz + " " + x._1 + " = " + batch + ".column(" + x._2 +
");\n").trim} )
--- End diff --
I'm not sure what's the impact on performance, since you are optimizing the
these for performance, it's better to figure it out.
If it's trivial, we may do not need this variable, just use
`batch.column(ordinal).getInt(idx)` in InputReference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
