Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56454520
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -189,9 +199,9 @@ class RFormula(override val uid: String) extends
Estimator[RFormulaModel] with R
@Experimental
class RFormulaModel private[feature](
override val uid: String,
- resolvedFormula: ResolvedRFormula,
- pipelineModel: PipelineModel)
- extends Model[RFormulaModel] with RFormulaBase {
+ private[ml] val resolvedFormula: ResolvedRFormula,
+ private[ml] val pipelineModel: PipelineModel)
--- End diff --
I prefer to leave the private scope of ml, other than feature, because
CrossValidator accesses the pipelineModel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
