Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9884#discussion_r56428307
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -298,4 +412,51 @@ private class VectorAttributeRewriter(
}
override def copy(extra: ParamMap): VectorAttributeRewriter =
defaultCopy(extra)
+
+ @Since("2.0.0")
+ override def write: MLWriter = new
VectorAttributeRewriter.VectorAttributeRewriterWriter(this)
+}
+
+@Since("2.0.0")
+private object VectorAttributeRewriter extends
MLReadable[VectorAttributeRewriter] {
+
+ @Since("2.0.0")
+ override def read: MLReader[VectorAttributeRewriter] = new
VectorAttributeRewriterReader
+
+ @Since("2.0.0")
+ override def load(path: String): VectorAttributeRewriter =
super.load(path)
+
+ /** [[MLWriter]] instance for [[VectorAttributeRewriter]] */
+ private[VectorAttributeRewriter]
+ class VectorAttributeRewriterWriter(instance: VectorAttributeRewriter)
extends MLWriter {
+
+ private case class Data(vectorCol: String, prefixesToRewrite:
Map[String, String])
+
+ override protected def saveImpl(path: String): Unit = {
+ // Save metadata and Params
+ DefaultParamsWriter.saveMetadata(instance, path, sc)
+ // Save model data: vectorCol, prefixesToRewrite
+ val data = Data(instance.vectorCol, instance.prefixesToRewrite)
+ val dataPath = new Path(path, "data").toString
+
sqlContext.createDataFrame(Seq(data)).repartition(1).write.parquet(dataPath)
+ }
+ }
+ private class VectorAttributeRewriterReader extends
MLReader[VectorAttributeRewriter] {
--- End diff --
newline
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
