Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11578#discussion_r56619813
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -41,6 +41,12 @@ trait RandomSampler[T, U] extends Pseudorandom with
Cloneable with Serializable
/** take a random sample */
def sample(items: Iterator[T]): Iterator[U]
--- End diff --
I think if we want to keep it (which could make sense) - we should maybe
add a default implementation for it so we don't have duplicate sampling logic
(as we do right now in the classes)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
