Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11578#issuecomment-197623339
Do we generate more random numbers than iterator call? I think it should be
the same. Besides, the non-iterator api should only be used in Sampler codegen
#11517. It is expensive to create a new iterator from values passed from
Sampler node's child operator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
