Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11326#discussion_r57471934
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -157,12 +157,14 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
// SPARK-10873 added the lastUpdated field for each application's
attempt,
// the REST API returns the last modified time of EVENT LOG file for
this field.
// It is not applicable to hard-code this dynamic field in a static
expected file,
- // so here we skip checking the lastUpdated field's value (setting
it as "").
+ // so here we skip checking the lastUpdated field's value (setting
it as 0).
val json = if (jsonOrg.indexOf("lastUpdated") >= 0) {
val subStrings = jsonOrg.split(",")
for (i <- subStrings.indices) {
- if (subStrings(i).indexOf("lastUpdated") >= 0) {
- subStrings(i) = "\"lastUpdated\":\"\""
+ if (subStrings(i).indexOf("lastUpdatedEpoch") >= 0) {
+ subStrings(i) = "\"lastUpdatedEpoch\":0"
+ } else if (subStrings(i).indexOf("lastUpdated") >= 0) {
+ subStrings(i) = "\"lastUpdated\":0"
--- End diff --
`lastUpdated` is a string (representing a date). `lastUpdatedEpoch` is an
integer. They should be treated differently. The dummy value of a string here
is "" and for an integer is 0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
