Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11326#discussion_r57513179
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala
---
@@ -69,6 +69,8 @@ private[spark] object ApplicationsListResource {
attempts = app.attempts.map { internalAttemptInfo =>
new ApplicationAttemptInfo(
attemptId = internalAttemptInfo.attemptId,
+ startTimeEpoch = internalAttemptInfo.startTime,
--- End diff --
@ajbozarth thank you for your patience, this is pretty close now. I
apologize, I haven't really been paying attention to the rest of this change.
It is conceptually fine but actually, this part of the change is not necessary.
You've already got `Date` objects encoding the the time in this object, which
is really a fancy wrapper around ms since the epoch. `getTime` gets you the
same value you're adding here already. So I don't think it's necessary to
actually store all these values a second time.
Of course you still need to expose these values as an integer `Long` as
properties of the class, so that JSON will contain the second ms representation
of them. I think that only requires adding getter methods with the right name
to the class objects below, not actually adding redundant fields. How about
that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
