Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57546554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -109,9 +109,9 @@ case class Invoke(
targetObject: Expression,
functionName: String,
dataType: DataType,
- arguments: Seq[Expression] = Nil) extends Expression with
NonSQLExpression {
+ arguments: Seq[Expression] = Nil,
+ val nullable: Boolean = true) extends Expression with NonSQLExpression
{
--- End diff --
This looks tricky to me, invoking a method on an object should be always
nullable, as we have no idea what that method does. To fix the nullability lose
issue, how about we create a new expression called `GetExternalRowField`? We
can setup corrected nullability there and generate simpler code for this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
