Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11984#discussion_r57925823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala
---
@@ -114,6 +123,57 @@ object GenerateColumnAccessor extends
CodeGenerator[Seq[DataType], ColumnarItera
(createCode, extract + patch)
}.unzip
+ val accessorCode = accessorClasses.map { case (accessorCls,
shortAccCls) =>
+ s"""
+ private $accessorCls get${shortAccCls}(int idx) {
+ byte[] buffer = batch.buffers()[columnIndexes[idx]];
+ return new
$accessorCls(ByteBuffer.wrap(buffer).order(nativeOrder));
+ }
+ """
+ }
+ val accessorStructCode = accessorStructClasses.map {
+ case ((accessorCls, dtCls), (shortAccCls, shortDTCls)) =>
+ s"""
+ private $accessorCls get${shortAccCls}_${shortDTCls}(int idx) {
+ byte[] buffer = batch.buffers()[columnIndexes[idx]];
+ return new
$accessorCls(ByteBuffer.wrap(buffer).order(nativeOrder),
+ (${dtCls}) columnTypes[idx]);
+ }
+ """
+ }
+
+ /* 4000 = 64000 bytes / 16 (up to 16 bytes per one call)) */
+ val numberOfStatementsThreshold = 4000
--- End diff --
@davies , thank you for your comment. I did not know the limitation. Now, I
confirmed these methods are compiled as follows:
```
hotspot_pid19296.log:<nmethod compile_id='10059' compiler='C1' level='3'
entry='0x00007f03a9574500' size='3024' address='0x00007f03a95742d0'
relocation_offset='296' insts_offset='560' stub_offset='2096'
scopes_data_offset='2472' scopes_pcs_offset='2680' dependencies_offset='2984'
nul_chk_table_offset='2992' oops_offset='2424'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
hasNext ()Z' bytes='92' count='384' iicount='384' stamp='25.140'/>
```
```
hotspot_pid19296.log:<nmethod compile_id='11143' compiler='C1' level='3'
entry='0x00007f03a8ec0680' size='3656' address='0x00007f03a8ec0450'
relocation_offset='296' insts_offset='560' stub_offset='2352'
scopes_data_offset='2752' scopes_pcs_offset='3192' dependencies_offset='3592'
nul_chk_table_offset='3600' oops_offset='2664'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
next ()Lorg/apache/spark/sql/catalyst/InternalRow;' bytes='88' count='384'
iicount='384' stamp='34.011'/>
```
```
hotspot_pid19296.log:<nmethod compile_id='11144' compiler='C1' level='3'
entry='0x00007f03a9a5dbc0' size='226544' address='0x00007f03a9a5a890'
relocation_offset='296' insts_offset='13104' stub_offset='155280'
scopes_data_offset='163488' scopes_pcs_offset='198456'
dependencies_offset='222520' nul_chk_table_offset='222528' oops_offset='163432'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
extractors0$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='6867' count='391' iicount='391' stamp='34.105'/>
hotspot_pid19296.log:<nmethod compile_id='11255' compiler='C1' level='3'
entry='0x00007f03aa327e00' size='226632' address='0x00007f03aa324ad0'
relocation_offset='296' insts_offset='13104' stub_offset='155280'
scopes_data_offset='163472' scopes_pcs_offset='198544'
dependencies_offset='222608' nul_chk_table_offset='222616' oops_offset='163432'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
extractors2$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='7001' count='521' iicount='521' stamp='37.163'/>
hotspot_pid19296.log:<nmethod compile_id='11256' compiler='C1' level='3'
entry='0x00007f03aa35f380' size='226664' address='0x00007f03aa35c050'
relocation_offset='296' insts_offset='13104' stub_offset='155280'
scopes_data_offset='163472' scopes_pcs_offset='198552'
dependencies_offset='222632' nul_chk_table_offset='222640' oops_offset='163432'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
extractors4$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='7001' count='530' iicount='530' stamp='37.286'/>
hotspot_pid19296.log:<nmethod compile_id='11257' compiler='C1' level='3'
entry='0x00007f03aa396900' size='226664' address='0x00007f03aa3935d0'
relocation_offset='296' insts_offset='13104' stub_offset='155280'
scopes_data_offset='163472' scopes_pcs_offset='198552'
dependencies_offset='222632' nul_chk_table_offset='222640' oops_offset='163432'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
extractors5$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='7001' count='541' iicount='541' stamp='37.427'/>
hotspot_pid19296.log:<nmethod compile_id='11263' compiler='C1' level='3'
entry='0x00007f03aa3cde80' size='226632' address='0x00007f03aa3cab50'
relocation_offset='296' insts_offset='13104' stub_offset='155280'
scopes_data_offset='163472' scopes_pcs_offset='198544'
dependencies_offset='222608' nul_chk_table_offset='222616' oops_offset='163432'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
extractors1$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='7001' count='547' iicount='547' stamp='37.516'/>
hotspot_pid19296.log:<nmethod compile_id='11264' compiler='C1' level='3'
entry='0x00007f03aa405400' size='226664' address='0x00007f03aa4020d0'
relocation_offset='296' insts_offset='13104' stub_offset='155280'
scopes_data_offset='163472' scopes_pcs_offset='198552'
dependencies_offset='222632' nul_chk_table_offset='222640' oops_offset='163432'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
extractors3$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='7001' count='555' iicount='555' stamp='37.607'/>
```
```
hotspot_pid19296.log:<nmethod compile_id='10750' compiler='C1' level='3'
entry='0x00007f03a9fe9dc0' size='340208' address='0x00007f03a9fe5790'
relocation_offset='296' insts_offset='17968' stub_offset='182384'
scopes_data_offset='193120' scopes_pcs_offset='304680'
dependencies_offset='335480' handler_table_offset='335488'
nul_chk_table_offset='337840' oops_offset='192920'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
accessors0$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='5367' count='231' iicount='231' stamp='29.373'/>
hotspot_pid19296.log:<nmethod compile_id='10751' compiler='C1' level='3'
entry='0x00007f03aa03cec0' size='340528' address='0x00007f03aa038890'
relocation_offset='296' insts_offset='17968' stub_offset='182608'
scopes_data_offset='193296' scopes_pcs_offset='305000'
dependencies_offset='335800' handler_table_offset='335808'
nul_chk_table_offset='338160' oops_offset='193144'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
accessors1$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='5501' count='239' iicount='239' stamp='29.464'/>
hotspot_pid19296.log:<nmethod compile_id='11053' compiler='C1' level='3'
entry='0x00007f03aa1c74c0' size='340528' address='0x00007f03aa1c2e90'
relocation_offset='296' insts_offset='17968' stub_offset='182608'
scopes_data_offset='193296' scopes_pcs_offset='305000'
dependencies_offset='335800' handler_table_offset='335808'
nul_chk_table_offset='338160' oops_offset='193144'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
accessors2$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='5501' count='367' iicount='367' stamp='32.552'/>
hotspot_pid19296.log:<nmethod compile_id='11056' compiler='C1' level='3'
entry='0x00007f03aa227c40' size='340528' address='0x00007f03aa223610'
relocation_offset='296' insts_offset='17968' stub_offset='182608'
scopes_data_offset='193296' scopes_pcs_offset='305000'
dependencies_offset='335800' handler_table_offset='335808'
nul_chk_table_offset='338160' oops_offset='193144'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
accessors5$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='5501' count='370' iicount='370' stamp='32.699'/>
hotspot_pid19296.log:<nmethod compile_id='11054' compiler='C1' level='3'
entry='0x00007f03aa27ec40' size='340528' address='0x00007f03aa27a610'
relocation_offset='296' insts_offset='17968' stub_offset='182608'
scopes_data_offset='193296' scopes_pcs_offset='305000'
dependencies_offset='335800' handler_table_offset='335808'
nul_chk_table_offset='338160' oops_offset='193144'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
accessors3$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='5501' count='370' iicount='370' stamp='32.948'/>
hotspot_pid19296.log:<nmethod compile_id='11055' compiler='C1' level='3'
entry='0x00007f03aa2d1e80' size='340528' address='0x00007f03aa2cd850'
relocation_offset='296' insts_offset='17968' stub_offset='182608'
scopes_data_offset='193296' scopes_pcs_offset='305000'
dependencies_offset='335800' handler_table_offset='335808'
nul_chk_table_offset='338160' oops_offset='193144'
method='org/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator
accessors4$
(Lorg/apache/spark/sql/catalyst/expressions/GeneratedClass$SpecificColumnarIterator;)V'
bytes='5501' count='369' iicount='369' stamp='33.083'/>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
