Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11984#discussion_r57931259
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala
---
@@ -114,6 +123,61 @@ object GenerateColumnAccessor extends
CodeGenerator[Seq[DataType], ColumnarItera
(createCode, extract + patch)
}.unzip
+ val accessorCode = accessorClasses.map { case (accessorCls,
shortAccCls) =>
+ s"""
+ private $accessorCls get${shortAccCls}(int idx) {
+ byte[] buffer = batch.buffers()[columnIndexes[idx]];
+ return new
$accessorCls(ByteBuffer.wrap(buffer).order(nativeOrder));
+ }
+ """
+ }
+ val accessorStructCode = accessorStructClasses.map {
+ case ((accessorCls, dtCls), (shortAccCls, shortDTCls)) =>
+ s"""
+ private $accessorCls get${shortAccCls}_${shortDTCls}(int idx) {
+ byte[] buffer = batch.buffers()[columnIndexes[idx]];
+ return new
$accessorCls(ByteBuffer.wrap(buffer).order(nativeOrder),
+ (${dtCls}) columnTypes[idx]);
+ }
+ """
+ }
+
+ /*
+ * 500 = 7500 bytes / 15 (up to 15 bytes per one call))
+ * the maximum byte code size to be compiled for HotSpot is 8000.
+ * We should keep less than 8000
+ */
+ val numberOfStatementsThreshold = 500
+ val (initializerAccessorFuncs, initializerAccessorCalls,
extractorFuncs, extractorCalls) =
+ if (initializeAccessors.length <= numberOfStatementsThreshold) {
+ ("", initializeAccessors.mkString("\n"), "",
extractors.mkString("\n"))
+ } else {
+ val groupedAccessorsItr =
initializeAccessors.grouped(numberOfStatementsThreshold)
+ var groupedAccessorsLength = 0
--- End diff --
Should this just be `groupedAccessorsItr.size()` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
