Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11989#discussion_r58239918 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -509,6 +510,25 @@ class RandomForestSuite extends SparkFunSuite with MLlibTestSparkContext { assert(mapToVec(map.toMap) ~== mapToVec(expected) relTol 0.01) } + test("options for feature subset size in RandomForest - SPARK-3724") { --- End diff -- There are already tests for feature subset strategy on L421. You can just add to those instead of creating this new test.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org