Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11989#discussion_r58240655
--- Diff:
mllib/src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java
---
@@ -80,6 +80,12 @@ public void runDT() {
for (String featureSubsetStrategy:
RandomForestClassifier.supportedFeatureSubsetStrategies()) {
rf.setFeatureSubsetStrategy(featureSubsetStrategy);
}
+ for (double featureSubsetFraction = 0.1; featureSubsetFraction <= 1.0;
featureSubsetFraction += 0.1) {
--- End diff --
I'm not sure there is a good reason to try out this many values. Perhaps
you can just add a couple different string test cases to the for loop above. I
don't see a reason to test every integer from 1 to 100, just a couple edge
cases should work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
