Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10628#issuecomment-204684533
So big endian implementations of OffHeapColumnVector and
OnHeapColumnVector are needed. I don't think we'd want to have an inline 'if
(bigEndian)' in the relevent methods so it may be that we'd want to subclass
those classes, override the methods which require handling big endian, and
instantiate the big endian version in ColumnVector.allocate if on a BE platform?
xxxHeapColumnVector classes would have to lose the 'final' attribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
