Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12169#discussion_r58493735
  
    --- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -75,17 +75,17 @@ statement
         | ALTER TABLE tableIdentifier NOT STORED AS DIRECTORIES            
#unstoreTable
         | ALTER TABLE tableIdentifier
             SET SKEWED LOCATION skewedLocationList                         
#setTableSkewLocations
    -    | ALTER TABLE tableIdentifier ADD (IF NOT EXISTS)?
    +    | ALTER kind=TABLE tableIdentifier ADD (IF NOT EXISTS)?
    --- End diff --
    
    Minor: we don't really need kind. We can also just check for the existance 
of the VIEW keyword, e.g.: `ctx.VIEW != null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to