Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12169#discussion_r58600702
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends AstBuilder {
        *   ALTER TABLE table ADD [IF NOT EXISTS] PARTITION spec [LOCATION 
'loc1']
        *   ALTER VIEW view ADD [IF NOT EXISTS] PARTITION spec
        * }}}
    +   *
    +   * ALTER VIEW ... DROP PARTITION ... is not supported because the 
concept of partitioning
    +   * is associated with physical tables
        */
       override def visitAddTablePartition(
           ctx: AddTablePartitionContext): LogicalPlan = withOrigin(ctx) {
    +    if (ctx.VIEW != null) throw new ParseException(s"Unsupported 
partitioned view", ctx)
    --- End diff --
    
    I think @yhuai prefers to say something like `Operation not allowed: 
partitioned views` for the message


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to