Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12166#discussion_r58582132
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
    @@ -758,6 +816,10 @@ class LDA @Since("1.6.0") (
       @Since("1.6.0")
       def setOptimizeDocConcentration(value: Boolean): this.type = 
set(optimizeDocConcentration, value)
     
    +  /** @group expertSetParam */
    +  @Since("2.0.0")
    +  def setKeepLastCheckpoint(value: Boolean): this.type = 
set(keepLastCheckpoint, value)
    +
    --- End diff --
    
    I don't think so.  Once there is a model, the decision about keeping the 
last checkpoint has already been made.  Users can manage the checkpoint via the 
deletion method though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to