Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12166#discussion_r58582117
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
    @@ -619,6 +651,31 @@ class DistributedLDAModel private[ml] (
       @Since("1.6.0")
       lazy val logPrior: Double = oldDistributedModel.logPrior
     
    +  private var _checkpointFiles: Array[String] = 
oldDistributedModel.checkpointFiles
    +
    +  /**
    +   * If using checkpointing and [[LDA.keepLastCheckpoint]] is set to true, 
then there may be
    +   * saved checkpoint files.  This method is provided so that users can 
manage those files.
    +   * Note that removing the checkpoints can cause failures if a partition 
is lost and is needed
    +   * by certain [[DistributedLDAModel]] methods.
    +   *
    +   * @return  Checkpoint files from training
    +   */
    +  @Since("2.0.0")
    +  def getCheckpointFiles: Array[String] = _checkpointFiles
    --- End diff --
    
    I'd like to give users a way to clean up manually, but I'll mark it as 
DeveloperApi.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to