Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12031#discussion_r58613857
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -178,6 +178,9 @@ private[spark] class Executor(
/** Whether this task has been killed. */
@volatile private var killed = false
+ /** Whether this task has been finished. */
+ @volatile private var finished = false
--- End diff --
You don't need to add `@volatile` since it's only accessed in the
`synchronized` blocks. Could you also add `GuardedBy` like this:
```
@GuardedBy("TaskRunner.this")
private var finished = false
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
