Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12031#discussion_r58614159
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -315,14 +326,23 @@ private[spark] class Executor(
} catch {
case ffe: FetchFailedException =>
val reason = ffe.toTaskEndReason
+ setTaskFinished(true)
+ // Reset the interrupted status of the thread to update the
status
+ Thread.interrupted()
--- End diff --
Could you move this into `setTaskFinished` and add comments to explain why
we need to clear the interrupted status and add the jira number to the comments
as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
