Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11989#discussion_r58832650
--- Diff:
mllib/src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java
---
@@ -80,6 +80,14 @@ public void runDT() {
for (String featureSubsetStrategy:
RandomForestRegressor.supportedFeatureSubsetStrategies()) {
rf.setFeatureSubsetStrategy(featureSubsetStrategy);
}
+ String realStrategies[] = {".1", ".10", "0.10", "0.1", "0.9", "1.0"};
+ for (String strategy: realStrategies) {
+ rf.setFeatureSubsetStrategy(strategy);
+ }
+ String integerStrategies[] = {"1", "10", "100", "1000", "10000"};
--- End diff --
Also, what happens with negative values? Those should not be allowed - just
want to confirm the regex excludes that (we should add some test cases)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
