Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12247#discussion_r59256046
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
 ---
    @@ -67,12 +62,33 @@ class FileStreamSource(
       }
     
       /**
    +   * Set the metadata path. This method should be called before using 
[[FileStreamSource]].
    +   */
    +  def setMetadataPath(metadataPath: String): Unit = {
    --- End diff --
    
    Sure, but if you find yourself hacking around the fact that we don't know 
some information at some point in the control flow and its making the 
implementation a lot more complicated, then we need to rethink the control flow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to