Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12247#discussion_r59280899
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -341,6 +347,33 @@ class FileStreamSourceSuite extends
FileStreamSourceTest with SharedSQLContext {
Utils.deleteRecursively(tmp)
}
+ test("metadataPath should be in checkpointLocation") {
--- End diff --
`metadataPath` is only for `FileStreamSource` so I think this test belongs
to `FileStreamSourceSuite`.
I added a test to test source ids in `DataFrameReaderWriterSuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
