Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59318015
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +158,7 @@ private[spark] class HttpServer(
throw new ServerStateException("Server is already stopped")
} else {
server.stop()
+ condOpt(server.getThreadPool) { case x: LifeCycle => x
}.foreach(_.stop())
--- End diff --
yea let's not use condOpt. It's too cryptic.
Do something more obvious, e.g.
```scala
if (server.getThreadPool != null) {
server.getThreadPool match {
case l: LifeCycle => l.stop()
case _ => // Do nothing
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
