Github user chtyim commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59331847
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +156,7 @@ private[spark] class HttpServer(
throw new ServerStateException("Server is already stopped")
} else {
server.stop()
+ Option(server.getThreadPool).collect { case x: LifeCycle => x
}.foreach(_.stop())
--- End diff --
I agree that when there are multiple chaining with not so obvious
function/partial function applications, scala can become unreadable. However,
for the case we are having here, I do think that using Option collect foreach
is quite straightforward and easily readable (and compare to someone chaining
multiple RDD operations, this is by far very readable).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
