Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59491556
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -790,14 +821,13 @@ class HiveCompatibilitySuite extends
HiveQueryFileTest with BeforeAndAfter {
"nullscript",
"optional_outer",
"orc_dictionary_threshold",
- "orc_empty_files",
"order",
"order2",
"outer_join_ppr",
"parallel",
"parenthesis_star_by",
"part_inherit_tbl_props",
- "part_inherit_tbl_props_empty",
+ //"part_inherit_tbl_props_empty", // TODO: results don't match
--- End diff --
This one and others that are commented out below are caused by differences
of describe table. There are mainly three differences. First, for managed
tables, we will EXTERNAL set to false in table properties. For tables that are
not bucketed, we will have numBuckets set to 0 instead of -1. For tables that
does not specify the file format, the output format will be
org.apache.hadoop.hive.ql.io.IgnoreKeyTextOutputFormat instead of
org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat (For Hive, it
somehow replaced even if the explain output still shows
IgnoreKeyTextOutputFormat). We do not need to block this PR for any of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
